Conversation
dkhokhlov
force-pushed
the
LOG-11814-error-handling
branch
5 times, most recently
from
c16f660 to
bb91457
Compare
dkhokhlov
force-pushed
the
LOG-11814-error-handling
branch
from
bb91457 to
83a68bf
Compare
dkhokhlov
force-pushed
the
LOG-11814-error-handling
branch
from
a4590a8 to
8bda0c4
Compare
dkhokhlov
force-pushed
the
LOG-11814-error-handling
branch
from
8bda0c4 to
25ed107
Compare
dkhokhlov
force-pushed
the
LOG-11814-error-handling
branch
from
4a5c80b to
2ecdcbe
Compare
dkhokhlov
force-pushed
the
LOG-11814-error-handling
branch
4 times, most recently
from
858bc3e to
ab1df06
Compare
stsantilena
reviewed
May 9, 2022
dkhokhlov
force-pushed
the
LOG-11814-error-handling
branch
from
ab1df06 to
37d45dd
Compare
dkhokhlov
force-pushed
the
LOG-11814-error-handling
branch
from
37d45dd to
bf9bf5c
Compare
stsantilena
reviewed
May 9, 2022
| else: | ||
| reason = response.reason | ||
|
|
||
| if 200 < status_code <= 399: |
There was a problem hiding this comment.
So only 200 would be expected code?
Contributor
Author
There was a problem hiding this comment.
yes, as successful, in this specific request.
stsantilena
approved these changes
May 9, 2022
stsantilena
left a comment
stsantilena
left a comment
There was a problem hiding this comment.
Just another small clarification. Other than that LGTM.
esatterwhite
approved these changes
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LOG-11814